Re: Why is src/test/modules/committs/t/002_standby.pl flaky?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why is src/test/modules/committs/t/002_standby.pl flaky?
Date: 2022-01-25 02:28:45
Message-ID: CA+hUKGLGtT0H-y2nchL1ZO116kEFxTzHkWsMjDUVKx=FY_CV2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 25, 2022 at 10:28 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-01-24 15:35:25 -0500, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > On 2022-01-14 17:51:52 -0500, Tom Lane wrote:
> > >> FWIW, I'm just fine with reverting, particularly in the back branches.
> > >> It seems clear that this dank corner of Windows contains even more
> > >> creepy-crawlies than we thought.
> >
> > > Seems we should revert now-ish? There's a minor release coming up and I think
> > > it'd be bad to ship these changes to users.
> >
> > Sure. Do we want to revert in HEAD too?
>
> Not sure. I'm also OK with trying to go with Thomas' patch to walreceiver and
> try a bit longer to get all this working. Thomas?

I vote for reverting in release branches only. I'll propose a better
WES patch set for master that hopefully also covers async append etc
(which I was already planning to do before we knew about this Windows
problem). More soon.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-25 02:36:09 Re: fairywren is generating bogus BASE_BACKUP commands
Previous Message Michael Paquier 2022-01-25 01:53:32 Re: typos