| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Spelling change in LLVM 14 API |
| Date: | 2021-10-26 01:21:40 |
| Message-ID: | CA+hUKGL-9iXkFix1NLPJq9xef3PfaUYd6qY5XF7EM+P+XmPRvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 26, 2021 at 1:52 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2021-10-26 13:39:53 +1300, Thomas Munro wrote:
> > According to my crystal ball, seawasp will shortly break again[1][2]
> > and the attached patch will fix it.
>
> That feels lot more convincing though. Based on past experience it's not hard
> to believe that the compile-time impact of the include the use of std::string
> forces into a lot of places is pretty significant...
>
> Could we make old case a wrapper around the new case that just passes on the
> error as a const char *? That should be more maintainable long-term, because
> there's only one copy of the body?
Here's one like that. The previous message "Track LLVM 14 API
changes" didn't seem too scalable so I added date and commit ID.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Track-LLVM-14-API-changes-2021-10-25.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2021-10-26 01:47:03 | Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT. |
| Previous Message | Michael Paquier | 2021-10-26 01:19:53 | Re: pgsql: Remove unused wait events. |