| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Spelling change in LLVM 14 API |
| Date: | 2021-10-26 00:51:57 |
| Message-ID: | 20211026005157.rc7yu6nmjfq6llvo@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-10-26 13:39:53 +1300, Thomas Munro wrote:
> On Mon, Sep 27, 2021 at 10:54 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > And pushed. Probably won't be the last change and seawasp only tests
> > master, so no back-patch for now.
>
> According to my crystal ball, seawasp will shortly break again[1][2]
> and the attached patch will fix it.
That feels lot more convincing though. Based on past experience it's not hard
to believe that the compile-time impact of the include the use of std::string
forces into a lot of places is pretty significant...
Could we make old case a wrapper around the new case that just passes on the
error as a const char *? That should be more maintainable long-term, because
there's only one copy of the body?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-26 01:15:40 | Re: pg_receivewal starting position |
| Previous Message | Thomas Munro | 2021-10-26 00:39:53 | Re: Spelling change in LLVM 14 API |