| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, didier <did447(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, buildfarm(at)coelho(dot)net |
| Subject: | Re: LLVM compile failing in seawasp |
| Date: | 2019-07-27 07:12:14 |
| Message-ID: | CA+hUKGKxQLVQ+W6fcvN5jPyPNX+6CAXDy0_n+xvWPnMn73O+wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 27, 2019 at 7:06 PM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> >>> c.h defines a C Min macro conflicting with llvm new class
> >>> llvm:ElementCount Min member
> >>
> >> Really? Well, we will hardly be the only code they broke with that.
> >> I think we can just wait for them to reconsider.
> >
> > FYI This is now on LLVM's release_90 branch, due out on August 28.
>
> Maybe we should consider doing an explicit bug report, but I would not bet
> that they are going to fold… or fixing the issue pg side, eg "pg_Min",
> less than 400 hundred instances, and backpatch to all supported
> versions:-(
I would just #undef Min for our small number of .cpp files that
include LLVM headers. It's not as though you need it in C++, which
has std::min() from <algorithm>.
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-07-27 09:40:35 | Re: LLVM compile failing in seawasp |
| Previous Message | Fabien COELHO | 2019-07-27 07:05:58 | Re: LLVM compile failing in seawasp |