Re: LLVM compile failing in seawasp

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, didier <did447(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, buildfarm(at)coelho(dot)net
Subject: Re: LLVM compile failing in seawasp
Date: 2019-07-27 09:40:35
Message-ID: CA+hUKG+vW2BHoJXJYhzBpzwC-pH854MguThsLewLcGh4pst0Jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 27, 2019 at 7:12 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sat, Jul 27, 2019 at 7:06 PM Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > Maybe we should consider doing an explicit bug report, but I would not bet
> > that they are going to fold… or fixing the issue pg side, eg "pg_Min",
> > less than 400 hundred instances, and backpatch to all supported
> > versions:-(
>
> I would just #undef Min for our small number of .cpp files that
> include LLVM headers. It's not as though you need it in C++, which
> has std::min() from <algorithm>.

Like so. Fixes the problem for me (llvm-devel-9.0.d20190712).

--
Thomas Munro
https://enterprisedb.com

Attachment Content-Type Size
0001-Avoid-macro-clash-with-LLVM-9.patch application/octet-stream 921 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2019-07-27 09:44:47 Re: Add parallelism and glibc dependent only options to reindexdb
Previous Message Thomas Munro 2019-07-27 07:12:14 Re: LLVM compile failing in seawasp