Re: [Patch] Windows relation extension failure at 2GB and 4GB

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Bryan Green <dbryan(dot)green(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Patch] Windows relation extension failure at 2GB and 4GB
Date: 2025-11-12 11:26:03
Message-ID: CA+hUKGKpcG_owGzyuL5J_g1yd1GFLaHJJNcwj8Qh0LuFRoUsLQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 12, 2025 at 11:55 PM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
> I just noticed that the check is for 2GB, but the error message says
> 1GB.

-Dsegsize only accepts integers here and it's expressed in GB, so only
1 will actually work. Presumably you could set a size up to 2GB - 1
block using -Dsegsize_blocks instead and it would work, but that's
clearly documented as developer-only. I noticed that too and
scratched my head for a moment, but I think Michael used a defensible
cut-off and a defensible error message, they just disagree :-)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pradeep Kumar 2025-11-12 11:26:35 Re: Assertion failure in SnapBuildInitialSnapshot()
Previous Message Michael Paquier 2025-11-12 11:25:43 Re: Extended Statistics set/restore/clear functions.