Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Wolfgang Walther <walther(at)technowledgy(dot)de>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-18 22:48:50
Message-ID: CA+hUKGK9LUq=uygBRFt3vFO1RL+_scsT4+hMkvea_zTttHZ59Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Mar 19, 2024 at 10:17 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> ... (though my patch could be a little sneakier and steal
> all the bytes right up to the = sign to get more space for our
> message!).

Here's one like that. No musl here -- does this work Wolfgang? Do we
think it's generous enough with space in practice that we could just
always do this for __linux__ systems without anyone noticing (ie
including glibc users)? Should we be more specific about which LD_*
variables? Do people not doing hacking/testing ever really set those,
eg on production servers? This code path was once used by up to a
dozen or so OSes but they're all dead, only Linux, Solaris and macOS
left, and I don't have any reason to think they suffer from this
problem and Macs don't even follow the SysV LD_ naming convention,
hence gating on Linux.

Attachment Content-Type Size
v2-0001-Don-t-clobber-LD_-environment-variables.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2024-03-18 23:23:44 BUG #18399: Query plan optimization results in runtime error when hoisting cast from inside subquery
Previous Message Dave Cramer 2024-03-18 22:36:08 Re: Postgres jdbc driver inconsistent behaviour with double precession

Browse pgsql-hackers by date

  From Date Subject
Next Message Paul Jungwirth 2024-03-18 22:49:28 Re: SQL:2011 application time
Previous Message Jeff Davis 2024-03-18 22:48:34 Re: Built-in CTYPE provider