| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeremy Schneider <schneider(at)ardentperf(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Built-in CTYPE provider |
| Date: | 2024-03-18 22:48:34 |
| Message-ID: | 7c48fd9170b69b5dce952741cdb257e8dce88f64.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2024-03-18 at 18:04 -0400, Tom Lane wrote:
> This is causing all CI jobs to fail the "compiler warnings" check.
I did run CI before checkin, and it passed:
https://cirrus-ci.com/build/5382423490330624
If I open up the windows build, I see the warning:
https://cirrus-ci.com/task/5199979044667392
but I didn't happen to check this time.
> Probably the best fix is the traditional
>
> return <something>; /* keep compiler quiet */
>
> but I'm not sure what the best default result is in this function.
In inverted the check so that I didn't have to choose a default.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-03-18 22:48:50 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Jacob Champion | 2024-03-18 22:39:27 | Re: sslinfo extension - add notbefore and notafter timestamps |