| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cleaning up historical portability baggage |
| Date: | 2022-08-06 00:44:48 |
| Message-ID: | CA+hUKGK=f5H6wdHyvhU0o3gXjn7Yg8QOpUe69H114Mb=4nJTbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 6, 2022 at 12:03 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> HAVE_GETTIMEOFDAY currently is only defined for mingw as the configure test is
> gated to windows - that's somewhat weird imo. mingw has had it since at least
> 2007. The attached patch makes the gettimeofday() fallback specific to msvc.
+1
> I've renamed the file to win32gettimeofday now. I wonder if we should rename
> files that are specific to msvc to indicate that? But that's for later.
+1, I was thinking the same.
> 1-arg gettimeofday() hasn't been around in a *long* while from what I can
> see. So I've removed that configure test.
+1
LGTM.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-06 00:52:04 | Re: Cleaning up historical portability baggage |
| Previous Message | Peter Geoghegan | 2022-08-06 00:39:56 | Remaining case where reltuples can become distorted across multiple VACUUM operations |