Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Dent John <denty(at)qqdd(dot)eu>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Roman Pekar <roma(dot)pekar(at)gmail(dot)com>
Subject: Re: [WIP] UNNEST(REFCURSOR): allowing SELECT to consume data from a REFCURSOR
Date: 2020-02-18 03:03:27
Message-ID: CA+hUKGJoe4uE4ce80BwDigL9zwHkeY98S_qqFQrCXVuMYvJD0w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 25, 2020 at 11:59 PM Dent John <denty(at)qqdd(dot)eu> wrote:
> Attached patch addresses these points, so should now apply cleanly agains dev.

From the trivialities department, I see a bunch of warnings about
local declaration placement (we're still using C90 rules for those by
project policy):

refcursor.c:138:3: error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
MemoryContext oldcontext =
MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);
^

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-02-18 03:17:22 Re: tiny documentation fix
Previous Message Thomas Munro 2020-02-18 02:56:15 Re: [HACKERS] WAL logging problem in 9.4.3?