Re: Optimising compactify_tuples()

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimising compactify_tuples()
Date: 2020-09-11 05:48:03
Message-ID: CA+hUKGJRtzbbhVmb83vbCiMRZ4piOAi7HWLCqs=GQ74mUPrP_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 11, 2020 at 3:53 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> That gets my benchmark down to 60.8 seconds, so 2.2 seconds better than v4b.

. o O ( I wonder if there are opportunities to squeeze some more out
of this with __builtin_prefetch... )

> I've attached v6b and an updated chart showing the results of the 10
> runs I did of it.

One failure seen like this while running check word (cfbot):

#2 0x000000000091f93f in ExceptionalCondition
(conditionName=conditionName(at)entry=0x987284 "nitems > 0",
errorType=errorType(at)entry=0x97531d "FailedAssertion",
fileName=fileName(at)entry=0xa9df0d "bufpage.c",
lineNumber=lineNumber(at)entry=442) at assert.c:67

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey M. Borodin 2020-09-11 06:02:06 Re: Yet another fast GiST build
Previous Message Thomas Munro 2020-09-11 05:44:24 Re: Optimising compactify_tuples()