| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: cpluspluscheck vs ICU |
| Date: | 2022-03-23 02:52:34 |
| Message-ID: | CA+hUKGJQjEbLM_qE-ebnd=iO-ZQ-X-uqZGOAmG99U-3PrZMWHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 23, 2022 at 3:23 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-03-22 17:20:24 -0700, Andres Freund wrote:
> > I was about to propose adding headerscheck / cpluspluscheck to the CI file so
> > that cfbot can catch future issues.
>
> The attached patch does so, with ICU disabled to avoid the problems discussed
> in the thread. Example run:
> https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0
>
> Unless somebody sees a reason not to, I'm planning to commit this soon.
LGTM.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-03-23 02:57:46 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |
| Previous Message | Kyotaro Horiguchi | 2022-03-23 02:51:25 | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |