| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | andres(at)anarazel(dot)de |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, ashu(dot)coek88(at)gmail(dot)com, sfrost(at)snowman(dot)net, pgsql(at)j-davis(dot)com, robertmhaas(at)gmail(dot)com, andrew(at)dunslane(dot)net, stark(at)mit(dot)edu, schneider(at)ardentperf(dot)com, bruce(at)momjian(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org, satyanarlapuram(at)gmail(dot)com, marvin_liang(at)qq(dot)com, actyzhang(at)outlook(dot)com |
| Subject: | Re: pg_walinspect - a new extension to get raw WAL data and WAL stats |
| Date: | 2022-03-23 02:57:46 |
| Message-ID: | 20220323.115746.609481851180412296.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 23 Mar 2022 11:51:25 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> The two places emit different outputs but the only difference is the
> delimiter between two blockrefs. (By the way, the current code forgets
> to insert a delimiter there). So even if the function took "bool
> is_waldump", it is used only when appending a line delimiter. It
> would be nicer if the "bool is_waldump" were "char *delimiter".
> Others might think differently, though..
>
> So, the function looks like this.
>
> StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
> uint32 &fpi_len);
By the way, xlog_block_info(at)xlogrecovery(dot)c has the subset of the
function. So the function can be shared with the callers of
xlog_block_info but I'm not sure it is not too-much...
StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
bool fpw_detail, uint32 &fpi_len);
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-03-23 03:23:02 | Re: Window Function "Run Conditions" |
| Previous Message | Thomas Munro | 2022-03-23 02:52:34 | Re: cpluspluscheck vs ICU |