| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED |
| Date: | 2023-03-15 21:13:56 |
| Message-ID: | CA+hUKG+pdM9v3Jv4tc2BFx2jh_daY3uzUyAGBhtDkotEQDNPYw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2023 at 2:00 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> 15.03.2023 11:43, Thomas Munro wrote:
> > Do you know how it fails in non-assert builds, without the fix?
> So at least with my test script that doesn't lead to a crash or something.
Thanks. We were wondering if the retry mechanism might somehow be
hiding this in non-assert builds, but, looking more closely, that is
tied specifically to the memory reservation operation.
I noticed that d41a178b missed a comment explaining why we used
malloc() instead of palloc(), but that isn't true anymore, so here's a
small patch to clean that up.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Small-tidyup-for-commit-d41a178b.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-03-15 21:21:49 | Re: Add support for DEFAULT specification in COPY FROM |
| Previous Message | Tom Lane | 2023-03-15 21:13:36 | Re: [PATCH] Add pretty-printed XML output option |