From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: A test for replay of regression tests |
Date: | 2022-01-21 02:42:26 |
Message-ID: | CA+hUKG+YyCzMnaOtzEunp14dohDo_f+g6gTQKU-eZHu_EKM2JA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jan 17, 2022 at 6:53 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Mon, Jan 17, 2022 at 05:25:19PM +1300, Thomas Munro wrote:
> > Here's how it failed on fairywren, in case someone knowledgeable of
> > MSYS path translation etc can spot the problem:
> You likely need a PostgreSQL::Test::Utils::perl2host() call. MSYS Perl
> understands Cygwin-style names like /home/... as well as Windows-style names,
> but this PostgreSQL configuration understands only Windows-style names.
Thanks. I added that and pushed. Let's see if fairywren likes it
when it comes back online.
I also learned that in the CI environment, node->basedir() is a path
containing an internal "." component (I mean "something/./something").
I added a regex to collapse those, because they're unacceptable in
Windows junction point targets. I'm aware that there is something
happening in another CF entry that might address that sort of
thing[1], so then perhaps I could remove the kludge.
I tested that with a throw-away change to .cirrus.yml, like so. The
CI thread[2] is discussing a proper solution to these Windows CI blind
spots.
test_modules_script:
- perl src/tools/msvc/vcregress.pl modulescheck
+ - perl src/tools/msvc/vcregress.pl taptest ./src/test/modules/test_misc
[1] https://commitfest.postgresql.org/36/3331/
[2] https://www.postgresql.org/message-id/20220114235457.GQ14051%40telsasoft.com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-01-21 03:04:02 | Re: row filtering for logical replication |
Previous Message | Michael Paquier | 2022-01-21 02:18:27 | Re: Refactoring of compression options in pg_basebackup |