| From: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] Unify duplicate-option handling across utility commands |
| Date: | 2026-10-07 17:39:37 |
| Message-ID: | CA+fm-ROpMi4+kYbepdWS2vr6ftVM-Db=Uhf6GrNuG3pNQ0-kGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I worked on unifying how the utility commands (VACUUM, ANALYZE, EXPLAIN,
CHECKPOINT, REPACK) handle duplicate options. It came up in one of my
patches here [1].
Based on that, I'm leaning towards last-wins rather than erroring on
duplicate options. It matches what REPACK/VACUUM/EXPLAIN already do, and
REPACK was recently fixed in-tree to be last-wins. But let me know your
feedback,
since COPY and WAIT FOR follow the error mechanism:
1/ is it better to have the error everywhere instead? Or
2/ go with the attached rough draft of the patch, which adds a centralized
helper that
collapses duplicates to last-wins and has each command called once?
Regards,
Baji Shaik
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Centralize-last-wins-handling-of-duplicate-utility-c.patch | application/octet-stream | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-10-07 17:41:13 | Re: fix more casting away of qualifiers |
| Previous Message | Jacob Champion | 2026-10-07 16:58:31 | Re: Adding init-po and update-po targets to the meson build system |