Re: fix more casting away of qualifiers

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Rui Zhao <zhaorui126(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fix more casting away of qualifiers
Date: 2026-10-07 17:41:13
Message-ID: 08796e63-9a2c-439c-b60e-01b0ae6b4801@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01.10.26 18:44, Rui Zhao wrote:
> One small thing in 0005, in src/backend/utils/adt/float.c: the comment
> above float8in_internal() still says:
>
>> "num" could validly be declared "const char *", but that results in an
>> unreasonable amount of extra casting both here and in callers,
>> so we don't.
> Could we remove those two lines now that num is const char *?

I have committed a few of these patches that did not receive any other
comments, and I will incorporate your feedback into the updated patch
series for the rest. Thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bohyun Lee 2026-10-07 17:44:43 Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically
Previous Message Baji Shaik 2026-10-07 17:39:37 [PATCH] Unify duplicate-option handling across utility commands