| From: | Stepan Neretin <slpmcf(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Assert "target_wal_endrec == divergerec" in pg_rewind |
| Date: | 2026-11-20 07:36:16 |
| Message-ID: | CA+Yyo5T_4xcxO3Gf4aNxVrRvfjFD3BKp2pyAgcMHFtmhgvEYoA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 20, 2026 at 2:48 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 16 Nov 2026, at 20:13, Stepan Neretin <slpmcf(at)gmail(dot)com> wrote:
>
> > Attached is a small rebase on current master, with the TAP coverage
> > folded into "005_same_timeline.pl". No behaviour change outside
> > assertion builds.
>
> use warnings FATAL => 'all';
> +use PostgreSQL::Test::Cluster;
> use PostgreSQL::Test::Utils;
>
> The proposed TAP test breaks the current model where tests use the
> infrastructure in the RewindTest module. Is there a reason why this test
> should be different?
>
> > Does this still seem worth committing?
>
> From reading over the thread in which Heikki concluded it was a bogus
> Assert,
> I'd say it's still worth committing. I do think the TAP test should be in
> line
> with the other pg_rewind tests though.
>
> --
> Daniel Gustafsson
>
Hi Daniel,
Thanks for looking. Folding this into 005 was a mistake.
RewindTest is the usual primary/standby/promote/rewind cycle, and this
needs an older base backup as the target. Same reason 008 skips it. v2
leaves 005 alone and puts the coverage in 012_target_is_ancestor.pl,
along the lines of Heikki's earlier test.
Assert fix itself is unchanged.
Attached.
Regards,
Stepan Neretin
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-bogus-Assert-in-pg_rewind-ancestor-check.patch | text/x-patch | 1.2 KB |
| v2-0002-Add-TAP-test-for-ancestor-no-rewind-cases.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-11-20 07:38:19 | Re: [PATCH v2] Reject duplicate SQL/JSON PASSING argument names |
| Previous Message | Chao Li | 2026-11-20 07:34:28 | Re: psql: avoid over-reading unterminated prompt escapes |