Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)

From: Ishjaap Singh <ishjaap(dot)singh07(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql: Don't offer USING INDEX after REPACK (CONCURRENTLY) or (ANALYZE)
Date: 2026-11-16 01:21:11
Message-ID: CA+Y2Bmc1TcZcuKzkgmTEyz+X-OXLpYB_4F2MptpBKwBJC645AA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujii-san, Sho,

Thanks for looking at this, and Sho for testing it.

That makes sense to me. Nothing else in tab completion reads an option
list to decide what to offer next, and keeping that in sync with the
server isn't worth it here, since the server already rejects these
commands with a clear error ("REPACK (CONCURRENTLY) requires an
explicit table name"). I'll withdraw the patch, which also removes the
conflict with Sho's REPACK patch [1].

[1] https://commitfest.postgresql.org/patch/7611/

Thanks,
Ishjaap Singh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-11-16 01:26:47 Simplify parallel apply worker error reporting mechanism
Previous Message Peter Smith 2026-11-16 00:59:08 Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables.