| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ThisTimeLineID in checkpointer and bgwriter processes |
| Date: | 2012-12-20 13:32:36 |
| Message-ID: | CA+U5nMJErpTuSSDAvPtHE8HFGJhERWq7_TXZTmV+_kTg582inA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 December 2012 13:19, Amit Kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
>> So I think we're good on that front. But I'll add a comment there, and
>> use 0 explicitly instead of ThisTimeLineID, for clarity.
>
> True, it might not have any functionality effect in RemoveOldXlogFiles().
> However it can be used in PreallocXlogFiles()->XLogFileInit() as well.
PreallocXlogFiles() should have been put to the sword long ago. It's a
performance tweak aimed at people without a performance problem in
this area.
I'll happily accept this excuse to remove it.
We can discuss whether any replacement is required.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-12-20 13:39:20 | Re: ThisTimeLineID in checkpointer and bgwriter processes |
| Previous Message | Amit Kapila | 2012-12-20 13:19:37 | Re: ThisTimeLineID in checkpointer and bgwriter processes |