| From: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
|---|---|
| To: | "'Simon Riggs'" <simon(at)2ndQuadrant(dot)com> |
| Cc: | "'Heikki Linnakangas'" <hlinnakangas(at)vmware(dot)com>, "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ThisTimeLineID in checkpointer and bgwriter processes |
| Date: | 2012-12-20 14:08:47 |
| Message-ID: | 007101cddebb$87cd6d10$97684730$@kapila@huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, December 20, 2012 7:03 PM Simon Riggs wrote:
> On 20 December 2012 13:19, Amit Kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
>
> >> So I think we're good on that front. But I'll add a comment there,
> and
> >> use 0 explicitly instead of ThisTimeLineID, for clarity.
> >
> > True, it might not have any functionality effect in
> RemoveOldXlogFiles().
> > However it can be used in PreallocXlogFiles()->XLogFileInit() as
> well.
>
> PreallocXlogFiles() should have been put to the sword long ago. It's a
> performance tweak aimed at people without a performance problem in
> this area.
Yes, it seems to be for a rare scenario.
> I'll happily accept this excuse to remove it.
>
> We can discuss whether any replacement is required.
We should think of alternatives if there is no other reasonable fix for the
problem.
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-12-20 14:11:46 | Re: Parser Cruft in gram.y |
| Previous Message | Simon Riggs | 2012-12-20 13:55:40 | Re: Parser Cruft in gram.y |