Re: Patch for option in pg_resetxlog for restore from WAL files

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Amit kapila <amit(dot)kapila(at)huawei(dot)com>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com>
Subject: Re: Patch for option in pg_resetxlog for restore from WAL files
Date: 2012-09-25 12:56:36
Message-ID: CA+U5nM+dWnsBJje6e-f1K3uHMb0WBRwfgKM4hH3K_gT2detKgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24 September 2012 04:00, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
> On 18.07.2012 16:47, Amit kapila wrote:
>>
>> Patch implementing the design in below mail chain is attached with this
>> mail.
>
>
> This patch copies the ReadRecord() function and a bunch of related functions
> from xlog.c into pg_resetxlog.c. There's a separate patch in the current
> commitfest to make that code reusable, without having to copy-paste it to
> every tool that wants to parse the WAL. See
> https://commitfest.postgresql.org/action/patch_view?id=860. This patch
> should be refactored to make use of that framework, as soon as it's
> committed.

Agreed, moving to next commitfest.

Amit, suggest review of the patch that this now depends upon.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-09-25 12:58:49 Re: Switching timeline over streaming replication
Previous Message Michael Paquier 2012-09-25 11:48:34 Re: pg_reorg in core?