Re: Patch for option in pg_resetxlog for restore from WAL files

From: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>
To: "'Simon Riggs'" <simon(at)2ndQuadrant(dot)com>, "'Heikki Linnakangas'" <hlinnakangas(at)vmware(dot)com>
Cc: <robertmhaas(at)gmail(dot)com>, <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>, "'Andres Freund'" <andres(at)2ndquadrant(dot)com>
Subject: Re: Patch for option in pg_resetxlog for restore from WAL files
Date: 2012-09-25 13:30:10
Message-ID: 007e01cd9b21$e36e86f0$aa4b94d0$@kapila@huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, September 25, 2012 6:27 PM Simon Riggs wrote :
> On 24 September 2012 04:00, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
> > On 18.07.2012 16:47, Amit kapila wrote:
> >>
> >> Patch implementing the design in below mail chain is attached with
> this
> >> mail.
> >
> >
> > This patch copies the ReadRecord() function and a bunch of related
> functions
> > from xlog.c into pg_resetxlog.c. There's a separate patch in the
> current
> > commitfest to make that code reusable, without having to copy-paste
> it to
> > every tool that wants to parse the WAL. See
> > https://commitfest.postgresql.org/action/patch_view?id=860. This
> patch
> > should be refactored to make use of that framework, as soon as it's
> > committed.
>
> Agreed, moving to next commitfest.
>
> Amit, suggest review of the patch that this now depends upon.

Earlier I thought, I will try to finish in this CommitFest if the XLogReader
Patch gets committed by next week.
However if you feel it is better to work it for next CommitFest, I shall do
it that way.

With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-25 13:32:22 Re: Oid registry
Previous Message Simon Riggs 2012-09-25 13:25:16 One patch, one review