| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Peter Geoghegan <pg(at)heroku(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl> |
| Subject: | Re: RLS feature has been committed |
| Date: | 2014-09-26 09:12:30 |
| Message-ID: | CA+U5nM+BSKM0HbaTkYfByUgNt=2oJrr6_ij+QbAPPpQutcw+=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26 September 2014 08:48, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
> But in many cases, lack of good documentation makes even reviewing the patch
> difficult. How do you determine if the patch works as intended, if you don't
> know what it's supposed to do?
Exactly.
Lack of review and lack of consensus are often caused by the author
not making the patch fully and genuinely accessible to peer review.
Don't say you're having problems getting buy in when you've done very
little to encourage that. Committing early is not the solution.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2014-09-26 09:15:08 | Re: Replication identifiers, take 3 |
| Previous Message | Andres Freund | 2014-09-26 09:05:53 | Re: Replication identifiers, take 3 |