Re: pg_*_advice: tsv load failure, etc.

On Tue, Oct 20, 2026 at 2:59 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> Could you please look at instability in 001_persist.pl found by natural
> testing [1]:?
> [10:27:25.048](0.445s) # die: error running SQL: 'psql:<stdin>:2: ERROR: stash modifications are not allowed because "pg_stash_advice.tsv" has not been loaded yet'
> # while running 'psql --no-psqlrc --no-align --tuples-only --quiet --dbname port=29827 host=/tmp/o4DZxN3eiX dbname='postgres' --file - --variable ON_ERROR_STOP=1' with sql '
> # SELECT pg_create_advice_stash('stash_a');
> # SELECT pg_set_stashed_advice('stash_a', 1001, 'IndexScan(t)');
> # SELECT pg_set_stashed_advice('stash_a', 1002, E'line1\\nline2\\ttab\\\\backslash');
> # SELECT pg_set_stashed_advice('stash_a', 1003, '');
> # SELECT pg_create_advice_stash('stash_b');
> # SELECT pg_set_stashed_advice('stash_b', 2001, 'SeqScan(t)');
> # ' at /home/bf/bf-build/culicidae/REL_19_STABLE/pgsql/contrib/pg_stash_advice/t/001_persist.pl line 24.

I'm guessing that this is fixed by Zsolt's patch, which I just committed.

I also committed my previous round of fixes, so I think that closes
out this thread, and I have closed out the open item.

Again, if anyone finds more issues, please start new threads about
those, and add them to the open items list if 19final isn't out yet.
If you find issues later, feel free to send me an off-list email or PM
me on Discord to follow up, if I don't notice here.

Thanks,

--
Robert Haas
Databricks