Re: pg_*_advice: tsv load failure, etc.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Dongpo Liu <poe(dot)liu(at)pm(dot)me>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_*_advice: tsv load failure, etc.
Date: 2026-10-29 16:56:24
Message-ID: CA+Tgmoahs8rwxQHiQESHQeeX6hoKsE5WhvHGcjWNb+KW9_CQaA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 16, 2026 at 1:05 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> I/Claude noticed one more issue with pg_stash_advice:
> if the worker fails to write pg_stash_advice.tsv, the changes it was
> trying to save are treated as saved by the next worker.

Oops. Thanks for the patch. I committed it, but...

> A TAP test is included for reproduction and as a permanent test case
> if we want it.

...I decided against including the test case, and dropped it.

--
Robert Haas
Databricks

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-10-29 16:59:16 Re: pg_*_advice: tsv load failure, etc.
Previous Message Greg Burd 2026-10-29 16:42:53 Re: nbtree: opt-in leaf key prefix compression