Re: pgsql: Document XLOG_INCLUDE_XID a little better

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better
Date: 2021-10-01 13:45:47
Message-ID: CA+Tgmobvu6isesgdEvJdOc+f88FoGyHr5Rc=fYTrZvHqOU=Vtw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Oct 1, 2021 at 8:53 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I think a straight standalone variable (probably a static boolean in
> xloginsert.c) might be less confusing.

+1.

> ... so, reading the xact.c code again, TransactionState->assigned really
> means "whether the subXID-to-topXID association has been wal-logged",
> which is a completely different meaning from what the term 'assigned'
> means in all other comments in xact.c ... and I think the subroutine
> name MarkSubTransactionAssigned() is not a great choice either.

+1.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-10-01 15:10:38 pgsql: Fix Portal snapshot tracking to handle subtransactions properly.
Previous Message Alvaro Herrera 2021-10-01 12:53:48 Re: pgsql: Document XLOG_INCLUDE_XID a little better

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2021-10-01 13:53:23 Re: 2021-09 Commitfest
Previous Message Daniel Gustafsson 2021-10-01 13:19:30 Re: proposal: possibility to read dumped table's name from file