Re: make check false success

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Sandro Santilli <strk(at)kbt(dot)io>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make check false success
Date: 2017-06-05 15:42:39
Message-ID: CA+Tgmobt-PRPFFjEuCZYFZexoZQK2dKATE9zF+oW4E43WaHyuA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 5, 2017 at 5:23 AM, Sandro Santilli <strk(at)kbt(dot)io> wrote:
> Why not ? The caller is attempting to make an unsupported target,
> how's that different from calling `make unexistent` ?

That's a good point, but what Tom wrote is along the lines of my
concerns also, especially his last paragraph about REGRESS not being
defined at all. I think we have a convention that 'make check'
succeeds if it runs all of the tests, even if the set of all tests
happens to be the empty set.

What was your motivation for wanting this changed in the first place?
It seems like either behavior could be more convenient for someone,
depending on the context.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-05 16:19:01 Re: shm_toc_lookup API
Previous Message Robert Haas 2017-06-05 15:36:40 Re: shm_toc_lookup API