Re: make check false success

From: Sandro Santilli <strk(at)kbt(dot)io>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make check false success
Date: 2017-06-05 09:23:57
Message-ID: 20170605092357.4b6ejmbnt2imliaw@liz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 02, 2017 at 08:20:25AM -0400, Robert Haas wrote:
> On Thu, Jun 1, 2017 at 10:18 AM, Sandro Santilli <strk(at)kbt(dot)io> wrote:
> > I noticed that the `check` Makefile rule imported by PGXS is giving
> > a success exit code even when it is unsupported.
> >
> > The attached patch fixes that.
>
> Hmm. I'm not 100% sure that the existing behavior is wrong.

Why not ? The caller is attempting to make an unsupported target,
how's that different from calling `make unexistent` ?

--strk;

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2017-06-05 09:25:26 Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Previous Message Heikki Linnakangas 2017-06-05 09:08:05 Re: Challenges preventing us moving to 64 bit transaction id (XID)?