Re: PathNameCreateTemporaryDir() vs concurrency

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: PathNameCreateTemporaryDir() vs concurrency
Date: 2017-12-27 19:01:07
Message-ID: CA+TgmobmvG_VrYu6uhipCDKQYsp+KANkwQ4dXTjFuKS0NigRnQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 26, 2017 at 3:11 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> While testing parallel hash join today, I saw a couple of errors like this:
>
> 2017-12-26 23:34:37.402 NZDT [13082] ERROR: cannot create temporary
> subdirectory "base/pgsql_tmp/pgsql_tmp13080.0.sharedfileset": File
> exists
>
> There is a thinko in PathNameCreateTemporaryDir(), a new function
> added in commit dc6c4c9d. It was designed to tolerate directories
> existing already but forgot to handle it in the third mkdir call, so
> it fails with unlucky timing. Please see attached.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-27 19:03:37 Re: Comment typo in postgres_fdw.c
Previous Message Robert Haas 2017-12-27 18:53:49 Re: How to Works with Centos