Re: pgsql: Recursively fsync() the data directory after a crash.

On Mon, May 18, 2015 at 11:04 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, May 17, 2015 at 9:44 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>> If there a reason why in pre_sync_fname(), the error message does not
>>> contain a %m?
>
>> For consistency with the rest of the file, I suppose. Not sure why
>> it's like that, but all the functions in the file do it that way.
>
> Huh? All the ones that are reporting kernel call failures certainly
> have %m.

Oops, you're right. I was looking at the wrong code. Yeah, that
should probably be fixed. I'm not sure it's a good idea to do that
right now though.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company