Re: pgsql: Recursively fsync() the data directory after a crash.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Recursively fsync() the data directory after a crash.
Date: 2015-05-18 15:04:33
Message-ID: 14375.1431961473@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, May 17, 2015 at 9:44 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> If there a reason why in pre_sync_fname(), the error message does not
>> contain a %m?

> For consistency with the rest of the file, I suppose. Not sure why
> it's like that, but all the functions in the file do it that way.

Huh? All the ones that are reporting kernel call failures certainly
have %m.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-18 15:22:15 Re: pgsql: hstore_plpython: Fix regression tests under Python 3
Previous Message Tom Lane 2015-05-18 14:53:51 Re: pgsql: Separate block sampling functions