| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com> |
| Cc: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: backup manifests |
| Date: | 2020-03-20 22:29:48 |
| Message-ID: | CA+TgmobhNAHF1jqi9swroOqZgkcaGXNZG_bm8bdtHEJV=fmF3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 16, 2020 at 2:03 AM Suraj Kharage
<suraj(dot)kharage(at)enterprisedb(dot)com> wrote:
> One more suggestion, recent commit (1933ae62) has added the PostgreSQL home page to --help output.
Good catch. Fixed. I also attempted to address the compiler warning
you mentioned in your other email.
Also, I realized that the previous patch versions didn't handle the
hex-encoded path format that we need to use for non-UTF8 filenames,
and that there was no easy way to test that format. So, in this
version I added an option to force all pathnames to be encoded in that
format. I also made that option capable of suppressing the backup
manifest altogether. Other than that, this version is pretty much the
same as the last version, except for a few additional test cases which
I added to get the code coverage up even a little more. It would be
nice if someone could test whether the tests pass on Windows.
I have squashed the series down to just 2 commits, since that seems
like the way that this should probably be committed. Barring strong
objections and/or the end of the world, I plan to do that next week.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Add-checksum-helper-functions.patch | application/octet-stream | 9.6 KB |
| v12-0002-Generate-backup-manifests-for-base-backups-and-v.patch | application/octet-stream | 116.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jürgen Purtz | 2020-03-20 22:32:17 | Re: Add A Glossary |
| Previous Message | Mike Palmiotto | 2020-03-20 22:17:36 | Re: Auxiliary Processes and MyAuxProc |