Re: VACUUM fails to parse 0 and 1 as boolean value

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VACUUM fails to parse 0 and 1 as boolean value
Date: 2019-05-20 13:55:59
Message-ID: CA+TgmobcdBcpJg3G9PJHJ8N5qDATJLHm4u-DYqFPEAvwXYXcKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 16, 2019 at 9:21 PM Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I think we don't need to support 1/0 as boolean here (it's
> unnatural) and the documentation of VACUUM/ANALYZE should be
> fixed.

Well, it's confusing that we're not consistent about which spellings
are accepted. The GUC system accepts true/false, on/off, and 0/1, so
it seems reasonable to me to standardize on that treatment across the
board. That's not necessarily something we have to do for v12, but
longer-term, consistency is of value.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2019-05-20 14:03:40 Inaccurate header comment of issue_xlog_fsync_comment
Previous Message Tom Lane 2019-05-20 13:54:48 Re: Remove useless associativity/precedence from parsers