| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VACUUM fails to parse 0 and 1 as boolean value |
| Date: | 2019-05-16 19:29:36 |
| Message-ID: | CA+TgmobK1ngid9Pxs7g8RFQDH+O1X4yyL+vMQtaV7i6m-Xn0rw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 16, 2019 at 2:56 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Yes. Thanks for the comment!
> Attached is the updated version of the patch.
> It adds such common rule.
I'm not sure how much value it really has to define
opt_boolean_or_string_or_numeric. It saves 1 line of code in each of
3 places, but costs 6 lines of code to have it.
Perhaps we could try to unify at a higher level. Like can we merge
vac_analyze_option_list with explain_option_list?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-05-16 19:35:25 | Re: PostgreSQL 12: Feature Highlights |
| Previous Message | Stephen Amell | 2019-05-16 19:18:42 | Re: PostgreSQL 12: Feature Highlights |