Re: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()

On Tue, Oct 1, 2013 at 9:33 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Sun, 2013-09-15 at 18:27 +0200, Marko Tiikkaja wrote:
>> I think the reasoning behind this patch is sound. However, I would like
>> to raise a couple of small questions:
>>
>> 1) Is there a reason for the fmt string not being const char*? You
>> changed it for pg_log_v(), but not for pg_log() and pg_fatal().
>
> Good catch. I think I just left the existing code alone. I'll fix it.
>
>> 2) Allowing PG_FATAL to be passed to pg_log() seems weird, but I
>> don't feel strongly about that.
>
> Yeah, it's a bit weird. It's just because it all ends up in pg_log_v().
> We could have pg_log() error about it, but that seems a bit excessive.
> It's not a public API or anything.

Since there are several votes in favor of this patch and none opposed,
I'm marking it Ready for Committer.

Peter, do you plan to commit it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company