From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: multithreaded zstd backup compression for client and server |
Date: | 2022-03-30 15:44:27 |
Message-ID: | CA+Tgmob7VBkH_07MojFMJuQLHUEPHTkA0juzNAqgX+CjuwdQnA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 30, 2022 at 8:00 AM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > This patch contains a trivial adjustment to
> > PostgreSQL::Test::Cluster::run_log to make it return a useful value
> > instead of not. I think that should be pulled out and committed
> > independently regardless of what happens to this patch overall, and
> > possibly back-patched.
>
> run_log() is far from the only such method in PostgreSQL::Test::Cluster.
> Here's a patch that gives the same treatment to all the methods that
> just pass through to the corresponding PostgreSQL::Test::Utils function.
>
> Also attached is a fix a typo in the _get_env doc comment that I noticed
> while auditing the return values.
I suggest posting these patches on a new thread with a subject line
that matches what the patches do, and adding it to the next
CommitFest. It seems like a reasonable thing to do on first glance,
but I wouldn't want to commit it without going through and figuring
out whether there's any risk of anything breaking, and it doesn't seem
like there's a strong need to do it in v15 rather than v16.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2022-03-30 15:44:53 | Re: Granting SET and ALTER SYSTE privileges for GUCs |
Previous Message | Robert Haas | 2022-03-30 15:41:03 | Re: Correct docs re: rewriting indexes when table rewrite is skipped |