| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| Date: | 2015-09-14 20:25:52 |
| Message-ID: | CA+Tgmob3Jo_zi2GDkccHmhCCFtZGqZzYzaJfvZXMmJ_jeenAog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Sep 14, 2015 at 10:54 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> /*
>> - * We use UNION ALL rather than UNION; this might sometimes result in
>> - * duplicate entries in the OID list, but we don't care.
>> + * this might sometimes result in duplicate entries in the OID list,
>> + * but we don't care.
>> */
>>
>> This looks totally incoherent. You've removed the thing to which the
>> word "this" referred and replaced it with nothing.
>
>
> Oops.
>
> /*
> * The loop below runs multiple SELECTs might sometimes result in
> * duplicate entries in the OID list, but we don't care.
> */
>
> looks reasonable?
Sure, that seems fine.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-15 06:36:05 | pgsql: Fix wrong comment in commit d02426029b133ee2bbe492a038642359bce3 |
| Previous Message | Alvaro Herrera | 2015-09-14 18:12:17 | Re: pgsql: Allow per-tablespace effective_io_concurrency |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-14 20:31:59 | Re: Review: GiST support for UUIDs |
| Previous Message | Andrew Dunstan | 2015-09-14 20:24:45 | Re: cache type info in json_agg and friends |