| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| Date: | 2015-09-14 14:54:14 |
| Message-ID: | 55F6DF96.1060604@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> /*
> - * We use UNION ALL rather than UNION; this might sometimes result in
> - * duplicate entries in the OID list, but we don't care.
> + * this might sometimes result in duplicate entries in the OID list,
> + * but we don't care.
> */
>
> This looks totally incoherent. You've removed the thing to which the
> word "this" referred and replaced it with nothing.
Oops.
/*
* The loop below runs multiple SELECTs might sometimes result in
* duplicate entries in the OID list, but we don't care.
*/
looks reasonable?
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-09-14 18:12:17 | Re: pgsql: Allow per-tablespace effective_io_concurrency |
| Previous Message | Robert Haas | 2015-09-14 14:19:42 | Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-09-14 15:41:42 | Re: Move PinBuffer and UnpinBuffer to atomics |
| Previous Message | Robert Haas | 2015-09-14 14:19:42 | Re: [COMMITTERS] pgsql: Check existency of table/schema for -t/-n option (pg_dump/pg_res |