| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Ted Yu <yuzhihong(at)gmail(dot)com>, peter(at)eisentraut(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: redundant check of msg in does_not_exist_skipping |
| Date: | 2022-11-17 20:04:57 |
| Message-ID: | CA+Tgmob2-ubkmNZCkfs_8g4=MOtP+Kse2zrLFC5XMiAe7rZyFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 17, 2022 at 10:56 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> This is a completely bad idea. If it takes that level of analysis
> to see that msg can't be null, we should leave the test in place.
> Any future modification of either this code or what it calls could
> break the conclusion.
+1. Also, even if the check were quite obviously useless, it's cheap
insurance. It's difficult to believe that it hurts performance in any
measurable way. If anything, we would benefit from having more sanity
checks in our code, rather than fewer.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-11-17 20:06:43 | Re: Allow single table VACUUM in transaction block |
| Previous Message | Justin Pryzby | 2022-11-17 20:00:45 | Re: Allow single table VACUUM in transaction block |