Re: increase message string buffer size of watch command of psql

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: increase message string buffer size of watch command of psql
Date: 2016-06-13 01:20:48
Message-ID: CA+TgmoaxByA=d4F3Ld1MU+Ej7dEuDYZtMeCC1VCAkXhXeeGvTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 12, 2016 at 10:55 AM, Ioseph Kim <pgsql-kr(at)postgresql(dot)kr> wrote:
> Hello.
> In po.ko (korean message) at psql
> #: command.c:2971
> #, c-format
> msgid "Watch every %lds\t%s"
> msgstr "%ld초 간격으로 지켜보기\t%s"
>
> this message string is a cut string, because buffer size is small.
> At line 2946 in src/bin/psql/command.c
> char title[50];
>
> size of message string for korean is over 50 bytes.
> (at least 80 columns terminal for common)
>
> Increase size of this title, please.
> 50 bytes is so small for multi language.
>
> And. I suggest that date string might be local language,
> or current_timestamp string.

This was already changed in commit dea2b5960.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-06-13 01:52:55 Re: increase message string buffer size of watch command of psql
Previous Message Robert Haas 2016-06-13 01:16:44 Re: Rename max_parallel_degree?