| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve bytea error messages |
| Date: | 2014-07-09 15:05:49 |
| Message-ID: | CA+TgmoauwBR3mxKq3C7z+4dPjSQj1y9Pw8eikGP0mrxSk7vJzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 8, 2014 at 12:49 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 07/08/2014 07:44 AM, Robert Haas wrote:
>> On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>>> After someone reported somewhat less than informative errors in bytea
>>> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
>>> together a quick patch to improve the errors here.
>>
>> The first two changes seem fine from here, but I think the use of
>> parentheses in the third one likely violates our message style
>> guidelines.
>
> Good point.
>
> Better?
>
> Putting it in ERRHINT is more appropriate.
Looks OK to me. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-07-09 15:06:55 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Christoph Berg | 2014-07-09 14:57:21 | Re: postgresql.auto.conf and reload |