| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve bytea error messages |
| Date: | 2014-07-08 04:49:56 |
| Message-ID: | 53BB7874.3020204@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/08/2014 07:44 AM, Robert Haas wrote:
> On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>> After someone reported somewhat less than informative errors in bytea
>> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
>> together a quick patch to improve the errors here.
>
> The first two changes seem fine from here, but I think the use of
> parentheses in the third one likely violates our message style
> guidelines.
Good point.
Better?
Putting it in ERRHINT is more appropriate.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-bytea-decoding-error-messages.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2014-07-08 04:54:25 | Re: Extending constraint exclusion for implied constraints/conditions |
| Previous Message | Dilip kumar | 2014-07-08 04:28:05 | Re: Selectivity estimation for inet operators |