| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping PgStat_FunctionCallUsage for many expressions |
| Date: | 2016-11-26 15:45:11 |
| Message-ID: | CA+Tgmoaq7NgDnVeH9sU6thBQdBSiXtpDkpipxmCcgGAKMGHr7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> while working on my faster expression evaluation stuff I noticed that a
> lot of expression types that call functions don't call the necessary
> functions to make track_functions work.
>
> ExecEvalFunc/ExecEvalOper (via ExecMakeFunctionResultNoSets) call
> pgstat_init_function_usage/pgstat_end_function_usage, but others like
> ExecEvalRowCompare, ExecEvalMinMax, ExecEvalNullIf, ExecEvalDistinct,
> ExecEvalScalarArrayOp (and indirectly ExecEvalArrayCoerceExpr) don't.
>
> Similarly InvokeFunctionExecuteHook isn't used very thoroughly.
>
> Are these worth fixing? I suspect yes. If so, do we want to backpatch?
If it doesn't torpedo performance, I assume we should fix and back-patch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-26 16:06:26 | Re: Skipping PgStat_FunctionCallUsage for many expressions |
| Previous Message | Robert Haas | 2016-11-26 15:43:49 | Re: [RFC] Should we fix postmaster to avoid slow shutdown? |