Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()
Date: 2021-10-26 15:03:44
Message-ID: CA+Tgmoap5ZiFZw13qw6Swa5-GSu1_t4M+EeL+DryY3DaYRt5TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 26, 2021 at 7:54 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Another point that could be made is that perhaps
> MakeSingleTupleTableSlot should always construct a slot using virtual
> tuples rather than passing TTSOps as a parameter?

I haven't really looked at this issue deeply but that seems like it
might be a bit confusing. Then "single" would end up being an alias
for "virtual" which I don't suppose is what anyone is expecting.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-10-26 15:08:59 Re: Feature request for adoptive indexes
Previous Message Arjan van de Ven 2021-10-26 14:57:36 src/port/snprintf.c: Optimize the common base=10 case in fmtint