| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: using index or check in ALTER TABLE SET NOT NULL |
| Date: | 2017-11-30 20:55:00 |
| Message-ID: | CA+TgmoahVfu0dUmvM1bO3csn=DtFp1fG92995rjYD9u_kO-Y1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 29, 2017 at 11:53 AM, Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
> Here is new patch with check only existed valid constraints and without SPI at all.
Please use pgindent or anyway try to follow project style. { needs to
go on a line by itself, for example.
isSetNotNullNeedsTableScan seems different than other similarly-named
functions we have. NotNullImpliedByRelConstraints?
It also lacks a header comment.
Having both PartConstraintImpliedByRelConstraint and
ConstraintImpliedByRelConstraint with identical implementations
doesn't seem like a good idea to me. I guess just renaming it is
probably fine.
The comment /* T if we added new NOT NULL constraints */ should
probably be changed to /* T if we should recheck NOT NULL constraints
*/ or similar.
I'd suggest registering this with the next CommitFest.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-30 21:09:42 | Re: [HACKERS] CSV Logging questions |
| Previous Message | Alvaro Herrera | 2017-11-30 20:51:55 | Re: [HACKERS] Custom compression methods |