| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| Date: | 2022-07-27 18:13:57 |
| Message-ID: | CA+TgmoacMJUAGBSuHx3--=J=oHxNwCrP1n46r0F=HKjg+c=xuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Jul 27, 2022 at 1:42 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> If there's a magic number, then I'd (a) change that and (b) adjust
> whatever comments led you to think you shouldn't. Bumping catversion
> is a good fallback choice when there's not any more-proximate version
> indicator, but here there is.
Maybe I just got cold feet because it doesn't ever have seem to have
been changed before, because the definition says:
#define RELMAPPER_FILEMAGIC 0x592717 /* version ID value */
And the fact that "version" is in there sure makes it seem like a
version number, now that I look again.
I'll add 1 to the value.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-07-27 18:24:23 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| Previous Message | Robert Haas | 2022-07-27 18:08:21 | pgsql: Convert macros to static inline functions (buf_internals.h) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-27 18:22:20 | Re: Hash index build performance tweak from sorting |
| Previous Message | Robert Haas | 2022-07-27 18:09:19 | Re: making relfilenodes 56 bits |