From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
Date: | 2022-07-27 17:42:27 |
Message-ID: | 3017888.1658943747@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Jul 27, 2022 at 1:19 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> Another thing that seems to have happened here is that catversion ought
>> to have been touched and wasn't.
> Hmm, interesting. I didn't think about bumping catversion because I
> didn't change anything in the catalogs. I did think about changing the
> magic number for the file at one point, but unlike some of our other
> constants, there's no indication that this one is intended to be used
> as a version number. But in retrospect it would have been good to
> change something somewhere. If you want me to bump catversion now, I
> can. If you or someone else wants to do it, that's also fine.
If there's a magic number, then I'd (a) change that and (b) adjust
whatever comments led you to think you shouldn't. Bumping catversion
is a good fallback choice when there's not any more-proximate version
indicator, but here there is.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-07-27 18:08:21 | pgsql: Convert macros to static inline functions (buf_internals.h) |
Previous Message | Robert Haas | 2022-07-27 17:38:36 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-07-27 18:02:28 | Re: Use -fvisibility=hidden for shared libraries |
Previous Message | Robert Haas | 2022-07-27 17:38:36 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |