Re: Dependency between bgw_notify_pid and bgw_flags

On Mon, Aug 31, 2015 at 8:01 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
>> Thanks. It needs testing though to see if it really works as
>> intended. Can you look into that?
>
> PFA the patch containing your code changes + test module. See if that meets
> your expectations.

Thanks. I don't think this test module is suitable for commit for a
number of reasons, including the somewhat hackish use of exit(0)
instead of proper error reporting, the fact that you didn't integrate
it into the Makefile structure properly, and the fact that without the
postmaster.c changes it hangs forever instead of causing a test
failure. But it's sufficient to show that the code changes have the
intended effect.

I've committed this and back-patched it to 9.5, but not further. It's
a bug fix, but it's also a refactoring exercise, so I'd rather not
push it into released branches.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company