| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: C99 compliance for src/port/snprintf.c |
| Date: | 2018-08-15 14:58:54 |
| Message-ID: | CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Tue, Aug 14, 2018 at 7:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I'm almost tempted to think that the reasons above make this a
> back-patchable bug fix. Comments?
No objections to changing the behavior. Have you checked whether
there are any noticeable performance consequences?
Back-patching seems a bit aggressive to me considering that the danger
is hypothetical. I'd want to have some tangible evidence that
back-patching was going help somebody. For all we know somebody's got
an extension which they only use on Windows that happens to be relying
on the current behavior, although more likely still (IMHO) is that it
there is little or no code relying on either behavior.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-08-15 15:05:06 | Re: Facility for detecting insecure object naming |
| Previous Message | Robert Haas | 2018-08-15 14:51:44 | Re: libpq should append auth failures, not overwrite |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-15 15:41:46 | Re: C99 compliance for src/port/snprintf.c |
| Previous Message | Andreas 'ads' Scherbaum | 2018-08-15 07:57:38 | Re: Updating docbot URLs |